Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Twitter Login #782

Closed
wants to merge 27 commits into from
Closed

feat: Twitter Login #782

wants to merge 27 commits into from

Conversation

berry-13
Copy link
Collaborator

@berry-13 berry-13 commented Aug 9, 2023 •
edited
Loading

Added the possibility to login via Twitter.

⚠️I HAVE ADDED A FOLDER IN THE DOCUMENTS TO BETTER ORGANIZE THE FILES⚠️

Bugs:

  • Twitter icon is not visible.
  • It does not link the account to the existing one.

Change Type

  • New feature (non-breaking change which adds functionality)
  • Documentation update

Testing

test if the twitter login works correctly

Test Configuration:

I've had some issues because Twitter does NOT allow the use of localhost, so I tested on a private domain to see if it worked.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective or that my feature works
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@berry-13 berry-13 marked this pull request as ready for review August 10, 2023 10:04
@danny-avila
Copy link
Owner

do you mind setting up and running npm run e2e and share the results here? you will need to install playwright.

You will also need to make this file: e2e\config.local.ts

export default {
// input a real 'test' account that is registered on your app
  username: '[email protected]', 
  password: 'test_password',
};

danny-avila
danny-avila requested changes Aug 10, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@danny-avila danny-avila changed the title Twitter Login feat: Twitter Login Aug 10, 2023
@berry-13
Copy link
Collaborator Author

I've read some documentation both on Twitter and on Twitter's Passport.js, and it seems that other people are also facing the same issue with receiving the email... I believe you need to request the app to be whitelisted and have a paid API, which I don't think anyone wants to do😅. Here are a few links to better understand.

GET account/verify_credentials, Github Issue 1, Github Issue 2, stack overflow and Twitter Forum

@berry-13 berry-13 marked this pull request as draft August 11, 2023 13:50
@berry-13
Copy link
Collaborator Author

I will close this PR since no one is responding to the question I asked on the Twitter Developer Community. Therefore, it is impossible to proceed

@berry-13 berry-13 closed this Aug 15, 2023
@danny-avila
Copy link
Owner

I will close this PR since no one is responding to the question I asked on the Twitter Developer Community. Therefore, it is impossible to proceed

sorry to hear :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danny-avila danny-avila danny-avila requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@berry-13 @danny-avila @fuegovic